Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add index on permit history table #1670

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix: Add index on permit history table #1670

merged 1 commit into from
Nov 22, 2024

Conversation

john-fletcher-aot
Copy link
Collaborator

@john-fletcher-aot john-fletcher-aot commented Nov 22, 2024

Description

Added non-clustered index on ID and END_DATE_HIST to the ORBC_PERMIT_HIST audit table to avoid deadlock issues when updating multiple permit statuses at once (such as when multiple permits are purchased in the same transaction).

Fixes # ORV2-3080

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Ran update in local sql server, verified no errors in log console
  • After running update in local SQL server, verified index was present using SSMS
  • Manually created same index in test environment with reproducible error, confirmed index resolved error

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are promoted to:

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link

sonarcloud bot commented Nov 22, 2024

@john-fletcher-aot john-fletcher-aot merged commit ee79230 into main Nov 22, 2024
23 checks passed
@john-fletcher-aot john-fletcher-aot deleted the ORV2-3080 branch November 22, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants