Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide QAQC data from anon and BCeID users #208

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raarielgrace
Copy link
Contributor

@raarielgrace raarielgrace commented Nov 21, 2024

Description

Several bug fixes for the QA/QC dashboard and adjusting permissions so only IDIR users can access the data.

  • Fix property access bug that was stopping QA/QC table from displaying
  • Remove read access from public users of QA/QC data
  • Restrict access to IDIR (technically other users can visit the QA/QC webpage by going to /qaqc, but no data will be returned or displayed)

Fixes # 2334 (in gwells, not nr-gwells)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Mainly manual testing. Unsure if unit tests are needed. Permissions-based logic doesn't seem to have tests.

Blocks access of BCeID users as expected
Screenshot 2024-11-22 at 11 26 31 AM

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@raarielgrace raarielgrace linked an issue Nov 21, 2024 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restrict QA/QC Dashboard to IDIR users only
2 participants