Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): api return of aquifer notes #205

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lunamoonmoon
Copy link
Contributor

@lunamoonmoon lunamoonmoon commented Nov 20, 2024

Description

Fixed api returning aquifer notes (internal comments) to all users.

Fixes #126

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

notes field not returned if userRole !== aquifers.view
Screenshot 2024-11-19 at 3 57 39 PM
Screenshot 2024-11-19 at 3 21 00 PM


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@lunamoonmoon lunamoonmoon marked this pull request as ready for review November 20, 2024 18:45
@@ -107,7 +107,7 @@ const aquiferFixture = {
}

describe('View Component', () => {
let fetch = null
let fetch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was fetch changed to uninitialized instead of null?



</router-link-stub>
<!---->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were the changes made to this file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display comment box for internal users on the Aquifer Summary page
2 participants