Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Autocompletion search, refactored OMRR data filtering #175

Merged
merged 12 commits into from
Jul 17, 2024

Conversation

ccallendar
Copy link
Contributor

@ccallendar ccallendar commented Jul 15, 2024

Description

Lots of filtering related changes, including:

  • Changed the OmrrData interface slightly - adding new optional Postal Code field, which is extracted from the Facility Location field
  • Simplified the OMRR redux slice, especially the filtering fields. Changed from individual filter booleans to an array of filters that are more easily iterated over and used on the Authorization List and Map pages.
  • Added new omrr-utils.ts file which handles the filtering complexities, and keeps the omrr-slice.ts file focused on actions and state
  • Added match-sorter library for performing searching and sorting (recommended by MUI)
  • Added MUI Autocomplete component which supports Portal Code, Authorization Number, and Regulated Party searching
  • "City" autocompletion is not implemented yet

Fixes #106

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit tests
  • End to end tests

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mishraomp mishraomp requested a review from kdbelair July 16, 2024 18:31
kdbelair
kdbelair previously approved these changes Jul 16, 2024
Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-backend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jul 17, 2024

Quality Gate Passed Quality Gate passed for 'nr-omrr-transparency-frontend'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@mishraomp mishraomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccallendar ccallendar merged commit 8a2559e into main Jul 17, 2024
19 checks passed
@ccallendar ccallendar deleted the feat/autocomplete-search branch July 17, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search authorizations based on location from the map
3 participants