generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Autocompletion search, refactored OMRR data filtering #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccallendar
requested review from
mishraomp,
DerekRoberts and
AmanBhathal
as code owners
July 15, 2024 22:13
ccallendar
force-pushed
the
feat/autocomplete-search
branch
from
July 16, 2024 14:27
b02ba48
to
ea97e33
Compare
ccallendar
commented
Jul 16, 2024
ccallendar
commented
Jul 16, 2024
kdbelair
previously approved these changes
Jul 16, 2024
Quality Gate passed for 'nr-omrr-transparency-backend'Issues Measures |
Quality Gate passed for 'nr-omrr-transparency-frontend'Issues Measures |
mishraomp
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lots of filtering related changes, including:
Postal Code
field, which is extracted from theFacility Location
fieldomrr-utils.ts
file which handles the filtering complexities, and keeps theomrr-slice.ts
file focused on actions and statematch-sorter
library for performing searching and sorting (recommended by MUI)Autocomplete
component which supports Portal Code, Authorization Number, and Regulated Party searchingFixes #106
Type of change
How Has This Been Tested?
Checklist
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: