Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve problem details responses AB#16846 #6339

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Improve problem details responses AB#16846 #6339

merged 4 commits into from
Sep 16, 2024

Conversation

MikeLyttle
Copy link
Contributor

@MikeLyttle MikeLyttle commented Sep 16, 2024

Implements AB#16846

Description

  • configures back-end to return problem details responses instead of empty HTTP 401, 403, or other error responses
  • improves alignment of our custom problem details responses with the properties as defined in the RFC, using a URI for "type" and removing "instance"
  • replaces manual ProblemDetails creation with usage of built-in ProblemDetailsFactory
  • updates Swagger documentation to clarify HTTP 500-level response types return an object of type ProblemDetails (since only HTTP-400 level response types do this automatically)

Testing

  • Unit Tests Updated
  • Functional Tests Updated
  • Not Required

Items to Review:

@MikeLyttle MikeLyttle added this pull request to the merge queue Sep 16, 2024
Merged via the queue into dev with commit fa1e4a2 Sep 16, 2024
22 checks passed
@MikeLyttle MikeLyttle deleted the tasks/16846 branch September 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants