-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
369: Add unit to regulated product #2487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatchpole
force-pushed
the
369-add-unit-to-regulatedProduct
branch
3 times, most recently
from
November 20, 2024 00:01
d799799
to
951ffcf
Compare
acatchpole
force-pushed
the
369-add-unit-to-regulatedProduct
branch
2 times, most recently
from
November 20, 2024 23:35
2d00417
to
f3ec6aa
Compare
acatchpole
commented
Nov 21, 2024
bc_obps/registration/migrations/0057_regulatedproduct_add_isregulated_and_unit.py
Outdated
Show resolved
Hide resolved
dleard
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me
bc_obps/registration/migrations/0057_regulatedproduct_add_isregulated_and_unit.py
Outdated
Show resolved
Hide resolved
acatchpole
force-pushed
the
369-add-unit-to-regulatedProduct
branch
2 times, most recently
from
November 22, 2024 22:12
f99e0f1
to
8be529a
Compare
acatchpole
force-pushed
the
369-add-unit-to-regulatedProduct
branch
from
November 22, 2024 22:57
8be529a
to
88c8f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card
Changes:
unit
andis_regulated
fields toregulated_product
table. (Note: the ticket says the field should be "regulated" and i made the boolean field "is_regulated")regulated_product
tableTo Verify:
(mostly stolen from SH)
http://localhost:3000
Log in with Business BCeID
bc-cas-dev
Submit Annual Report(s)
Start
next to Operation 3 (an SFO)Save & Continue
Save & Continue
Production Data
Save & Continue
and see that the 'Unit' field is still populated (necessary b/c the unit value now comes from a different structure [see here where data source is different depending on if there is report_product data available])