-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24104 - Hide Fee Summary for Continuation Authorization #759
24104 - Hide Fee Summary for Continuation Authorization #759
Conversation
Signed-off-by: Qin <[email protected]>
Signed-off-by: Qin <[email protected]>
/gcbrun |
Temporary Url for review: https://business-create-dev--pr-759-q89jzfwo.web.app SB says, try this: https://business-create-dev--pr-759-q89jzfwo.web.app/continuation-in-authorization?id=TMYHLpcaq7&accountid=3040 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but don't merge until change is approved by Janis or Olga.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's decided that it's OK to hide the Fee Summary then please update App.vue line 486 (not needed).
Signed-off-by: Qin <[email protected]>
/gcbrun |
Temporary Url for review: https://business-create-dev--pr-759-q89jzfwo.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PS Did you catch Mihai's alternate solution? It was to create a zero-fee entry in the Pay db (using Pay Admin UI). Then we could use that fee code and override the payment text (done elsewhere already). However, Janis and Olga prefer the "hide" option, so that's what we're going with. |
Issue #: /bcgov/entity#24104
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).