Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24104 - Hide Fee Summary for Continuation Authorization #759

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

ArwenQin
Copy link
Collaborator

Issue #: /bcgov/entity#24104

Description of changes:

  • Hide the Fee Summary for Continuation Authorization

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@ArwenQin ArwenQin self-assigned this Nov 21, 2024
@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

bcregistry-sre commented Nov 21, 2024

@ArwenQin
Copy link
Collaborator Author

I'm confused why it shows $0 for staff, but $350 for regular user.
This is the header and response when it's staff (to Pay API):
image

image

This is the header and response when it's regular user:
image

image

Both params are the same and both have waiveFees=true. But the response is different.
For now, we hide the fee summary for continuation authorization.

@ArwenQin
Copy link
Collaborator Author

see:
https://business-create-dev--pr-759-q89jzfwo.web.app/continuation-in-authorization?id=TXXGAyWSS7&accountid=668

Hide fee:
image

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but don't merge until change is approved by Janis or Olga.

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's decided that it's OK to hide the Fee Summary then please update App.vue line 486 (not needed).

@ArwenQin
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://business-create-dev--pr-759-q89jzfwo.web.app

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@severinbeauvais
Copy link
Collaborator

PS Did you catch Mihai's alternate solution? It was to create a zero-fee entry in the Pay db (using Pay Admin UI). Then we could use that fee code and override the payment text (done elsewhere already). However, Janis and Olga prefer the "hide" option, so that's what we're going with.

@ArwenQin ArwenQin merged commit bfb7acc into bcgov:main Nov 25, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants