13577 Package changes for Vue3 (PROTOTYPE) #444
Conversation
- app version = 5.0.0 - DO NOT MERGE
severinbeauvais
force-pushed
the
13577
branch
from
81f17ed
to
61ae0fa
Compare
| '@vue/standard', | ||
| '@vue/typescript' | ||
| // '@vue/typescript/recommended' |
There was a problem hiding this comment.
I'm thinking lines 9 and 11 are worthy changes but I'm trying to limit the impact of the upgrade. We can use recommended lint rules -- and fix what it finds -- later.
| @@ -1,3 +1,3 @@ | |||
| > 1% | |||
| last 2 versions | |||
| not ie <= 10 | |||
| not dead | |||
There was a problem hiding this comment.
This should remove polyfills for IE11 and maybe other old browsers.
I saw somewhere that Vue3 is not compatible with IE11 anyway, so I think this is a good change.
| "@bcrs-shared-components/nature-of-business": "1.0.3", | ||
| "@bcrs-shared-components/staff-comments": "1.2.0", | ||
| "@bcrs-shared-components/staff-payment": "2.0.1", | ||
| "@bcrs-shared-components/web-chat": "2.0.0", |
There was a problem hiding this comment.
I had to remove these dependencies (and sbc-common-components below) because they are not upgraded and they cause package conflicts.
| "@bcrs-shared-components/staff-comments": "1.2.0", | ||
| "@bcrs-shared-components/staff-payment": "2.0.1", | ||
| "@bcrs-shared-components/web-chat": "2.0.0", | ||
| "@mdi/font": "^5.5.55", |
There was a problem hiding this comment.
I moved this to Dev Dependencies as per some examples I saw. It will be pretty obvious if this change doesn't work (once the project builds and runs).
| "@sentry/browser": "^5.21.1", | ||
| "@sentry/integrations": "^5.21.1", | ||
| "@vue/compat": "^3.2.39", |
There was a problem hiding this comment.
May not be needed if we don't need any Vue2 backward-compatibility features. See also compatConfig in vue.config.js.
If we go pure Vue3 then we probably don't need this package. To be determined later.
| "vue-the-mask": "^0.11.1", | ||
| "vue2-filters": "^0.10.0", | ||
| "vuelidate": "^0.7.5", | ||
| "vuetify": "^2.3.9", | ||
| "vuex": "^3.5.1" | ||
| "vuetify": "3.0.0-beta.4", |
There was a problem hiding this comment.
We really should postpone this upgrade until Vuetify is out of beta.
| "typescript": "^3.9.7", | ||
| "vue-cli-plugin-vuetify": "^2.0.7", | ||
| "typescript": "^4.8.3", | ||
| "vue-class-component": "8.0.0-rc.1", |
There was a problem hiding this comment.
We really should postpone this upgrade until this is released.
Possibly, if we refactor everything from Class API to the other option (not the same as Composition API) then we won't need this package or vue-property-decorator below.
| "vue-plugin-helper-decorator": "^0.0.12", | ||
| "vue-property-decorator": "^8.5.1", | ||
| "vue-template-compiler": "2.6.12", | ||
| "vue-property-decorator": "10.0.0-rc.3", |
There was a problem hiding this comment.
This package depends on vue-class-component above.
| "vuex-class": "^0.3.2", | ||
| "vuex-module-decorators": "^0.16.1" | ||
| "vuex-composition-helpers": "^1.1.2", | ||
| "vuex-module-decorators": "^2.0.0", |
There was a problem hiding this comment.
There's a lot of discussion on whether the store decorators work in Vue3. (I think they do but I didn't get far enough to test them.)
Since Vuex is deprecated in Vue3, there's also discussion about using pinia instead.
| "flush-promises": "^1.0.2", | ||
| "intersection-observer": "^0.12.0", | ||
| "s-vuex-class": "^0.4.1", |
There was a problem hiding this comment.
This may be a replacement or shim for the Vuex class decorators. See also vuex-module-decorators below.
There was a problem hiding this comment.
Ideally, we shouldn't have any shims or compatibility packages or other temporary code in our project (since that's tech debt).
| "vuex-module-decorators": "^0.16.1" | ||
| "vuex-composition-helpers": "^1.1.2", | ||
| "vuex-module-decorators": "^2.0.0", | ||
| "webpack-plugin-vuetify": "2.0.0-alpha.11" |
There was a problem hiding this comment.
I believe this replaces vuetify-loader in the old code.
| } | ||
| } | ||
| }) | ||
| }, |
There was a problem hiding this comment.
This config was recommended by the Vue3 migration site (see step 3).
If we go pure Vue3 then we probably don't need this config. To be determined later.
severinbeauvais
force-pushed
the
13577
branch
2 times, most recently
from
040c1e3
to
61ae0fa
Compare
severinbeauvais
changed the title
Issue #: bcgov/entity#13577
Description of changes:
Now,
npm isucceeds in this project (and npm lint). However, it still does not build (and cannot be tested) because a lot of code needs to be refactored. Also, all common and shared imports have been removed since they are not compatible at the moment. So this Pull Request is to show what packages need to be updated.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).