Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evmapy.py missing Y axis mappings #12928

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lulol
Copy link

@lulol lulol commented Nov 11, 2024

Fix #12927

@nadenislamarre
Copy link
Collaborator

"absbasey_positive = int(input.value) < 0" is obviously wrong (or the variable name must be changed)
let me try to reproduce and fix based on your code.
thanks.

Removed the absbasey_positive change from this PR, if that is an issue.
@lulol
Copy link
Author

lulol commented Nov 12, 2024

Ok. Removed the absbasey_positive change from this PR if that is an issue, since I didn't investigated much further how could affect other controllers.

As stated in the associated issue, in my particular case, all the game pads and controllers I tested show (up, left).min = 0 and (down, right).max = 255 and with the current logic the up/down axis is inverted, and just seems strange the logic mismatch between axes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evmapy.py generates an incomplete mapping file
2 participants