Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpinball configgen: pup support and 4:3 backglass ratio #11880

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toccata10
Copy link
Contributor

Pup Pack are becoming a reality for vpinball, so we need to position the windows easily.
I also added the possibility to force a 4:3 aspect ratio for the backglass on the 2nd screen.
Marking as draft as it works on my system, but I'm looking for some feedback and testing.

@nadenislamarre
Copy link
Collaborator

i guess that ratio screen243 should not be an option but something detected ?
is it game dependant ?
for the the name is not clear about what it must do. it looks like more a very custom case.
eventually, vpinball_pupbackglass_ratio ?

@toccata10
Copy link
Contributor Author

I don't know how the backglass ratio can be detected: it's probably in the directb2s file but I've no idea how to open that.
Unfortunately, the ratio is very game dependant. I've read in the forum that a guy took measurements of many different real backglasses and they were all different (manufacturer dependant and game dependant), but 4:3 is good approximation for all the traditional tables.
Can it be 16:9 ? yes it can. I've seen some directb2s creations in 16:9 (specially for original tables) or just because the guy had a 16:9 monitor and wanted no black bars around the backglass (and created some custom artwork).
The ratio for the pupbackglass is easier as it has to be always 16:9. Same for pupfulldmd.
Is the name screen2_ratio43 better for you ?
If we want to avoid stretching of the pupbackglass when we have flexdmd and pupbackglass on the 2nd screen, we should add an option with screen2_ratio169. But it seems so specific, that we can wait if the need appears before coding it (it's already quite complex imo).

A very cool feature is also this project: https://vpuniverse.com/files/file/16556-teachers-pet-williams-1965-169-background-for-43-b2s-backglass/
If I have time, maybe I'll experiment in a future version by creating a pygame window with this kind of background image at the beginning of the configgen before launching vpinball.

@toccata10
Copy link
Contributor Author

Discussing with you gives me more ideas...
A better solution would be to add a setting "backglass aspect ratio" with choices 4:3 and 16:9, and just keep the screen2 variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants