Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] use gogo protobuf fork #794

Draft
wants to merge 1 commit into
base: release-1.11
Choose a base branch
from
Draft

Conversation

waynz0r
Copy link
Member

@waynz0r waynz0r commented Nov 20, 2021

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Use github.com/waynz0r/protobuf gogo protobuf full fork and get rid of the replacement directive in go.mod. The protobuf fork was modified to be a full fork with changed import paths.

Why?

The fork is needed to support int64/uint64 marshalling to integers. Using the fork with replacement in go.mod made the api hard to use as the replacement was necessary everywhere locally.

@waynz0r waynz0r changed the title use gogo protobuf fork [v2] use gogo protobuf fork Nov 20, 2021
@waynz0r waynz0r marked this pull request as draft November 23, 2021 12:30
@waynz0r
Copy link
Member Author

waynz0r commented Nov 23, 2021

there are unmarshal issues, i set it to draft for now

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants