feat: added "linux" string as const

- because it has at least 3 occurrences in the package and the linter wanted to
banzaicloud · Aug 9, 2022 · 36bd672 · 36bd672
1 parent 2702884
commit 36bd672
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/cli/command/controlplane/init.go b/internal/cli/command/controlplane/init.go
@@ -205,7 +205,7 @@ func runInit(options initOptions, banzaiCli cli.Cli) error {
 		}
 		k8sContext = ""
 		log.Debugf("won't use local kubernetes context: %v", err)
-	} else if runtime.GOOS != "linux" {
+	} else if runtime.GOOS != linuxGOOS {
 		// non-native docker daemons can't access the host machine directly even if running in host networking mode
 		// we have to rewrite configs referring to localhost to use the special name `host.docker.internal` instead
 		k8sConfig, err = input.RewriteLocalhostToHostDockerInternal(k8sConfig)

diff --git a/internal/cli/command/controlplane/kind.go b/internal/cli/command/controlplane/kind.go
@@ -41,6 +41,7 @@ import (
 const version = "v0.9.0"
 const clusterName = "banzai"
 const kindCmd = "kind"
+const linuxGOOS = "linux"
 
 func isKINDInstalled(banzaiCli cli.Cli) bool {
 	path, err := findKINDPath(banzaiCli)
@@ -181,7 +182,7 @@ func ensureKINDCluster(banzaiCli cli.Cli, options *cpContext, listenAddress stri
 		return errors.WrapIf(err, "failed to get KIND kubeconfig")
 	}
 
-	if runtime.GOOS != "linux" {
+	if runtime.GOOS != linuxGOOS {
 		// non-native docker daemons can't access the host machine directly even if running in host networking mode
 		// we have to rewrite configs referring to localhost to use the special name `host.docker.internal` instead
 		_, err = input.RewriteLocalhostToHostDockerInternal(kubeconfig)
@@ -190,7 +191,7 @@ func ensureKINDCluster(banzaiCli cli.Cli, options *cpContext, listenAddress stri
 		}
 	}
 
-	if runtime.GOOS == "darwin" || runtime.GOOS == "linux" {
+	if runtime.GOOS == "darwin" || runtime.GOOS == linuxGOOS {
 		err = fixKind0_9_0KubeProxy(kubeconfig)
 		if err != nil {
 			return errors.Wrap(err, "failed to fix Kind v0.9.0 kube-proxy CrashLoopBackoff")