This repository has been archived by the owner on Jan 7, 2019. It is now read-only.
Add standard: what differences between iOS and android should I be aware of #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic reviewerscc: @louiszawadzki, @tychota Generated by 🚫 dangerJS |
pleportz
commented
Jul 19, 2018
| While coding I usually use the iOS simulator only. Most of the time, if the feature works on iOS then it works on android automatically. Of course there are a few exceptions: in this article you will find a non comprehensive list of caveats. | ||
|
|
||
|
|
||
| ### I modified the native code |
There was a problem hiding this comment.
check : il y a une différence de commit dans le dossier android ou dossier ios
pleportz
commented
Jul 19, 2018
|
|
||
| - References: See [How to add a native module](https://github.com/bamlab/dev-standards/blob/master/react-native/setup/add-native-module.mo.md) | ||
|
|
||
| ### I added a fixed height property to a component |
There was a problem hiding this comment.
i set the dimensions (width or height) of a component
There was a problem hiding this comment.
ajouter un exemple avec un screenshot
pleportz
commented
Jul 19, 2018
| shadowOpacity: 0.2, | ||
| shadowOffset: { height: 1, width: 1 }, | ||
| elevation: 3, | ||
| backgroundColor: 'white', // <-- backgroundColor is mandatory for android |
There was a problem hiding this comment.
ajouter un exemple avec screenshot
There was a problem hiding this comment.
premier step :
shadowColor: 'grey',
shadowRadius: 10,
shadowOpacity: 0.2,
shadowOffset: { height: 1, width: 1 },
==> ne sont que pour ios
- pour android :
c'est elevation + backgroundcolor sur au moins un des composants qui contient le composant en question+ margin qui fait le travail
pleportz
commented
Jul 19, 2018
| - Why: <TextInput /> does not render identically on android and iOS: | ||
|
|
||
| - With android you might need to specify the `underlineColorAndroid` prop (can be set to `"transparent"` for example) | ||
| - The vertical alignment of the input text is not the same. This can be solved by using a marginTop that depends on the platform: `marginTop: Platform.OS === 'ios ? ...'` |
There was a problem hiding this comment.
plutot mettre un padding: 0 sur le TextInput, sans distinction de plateforme
pleportz
commented
Jul 19, 2018
| - With android you might need to specify the `underlineColorAndroid` prop (can be set to `"transparent"` for example) | ||
| - The vertical alignment of the input text is not the same. This can be solved by using a marginTop that depends on the platform: `marginTop: Platform.OS === 'ios ? ...'` | ||
|
|
||
| ### I mistakenly added text direcly as a `<View />`'s child |
pleportz
commented
Jul 19, 2018
|
|
||
| ### I used a javascript function that is not implemented the same way in react-native's javascript interpreters for android and iOS | ||
|
|
||
| - Why: As of July 2018, react-native's javascript interpreter for android is a little bit late compared to iOS's. There are a few methods that just won't work with android: |
There was a problem hiding this comment.
There are a few methods that just won't work with android (non comprehensive list):
|
|
Et dans les dépendances :
|
pleportz
force-pushed
the
add-differences-android-ios
branch
from
0e49b06
to
e77e45b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.