Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flush resampling context #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Polochon-street
Copy link

Changed two things:
I saw rust-ffmpeg4-sys version was bumped, but it's still not working using 4.2.2 so just switched the branch to the stable version (it's failing anyways 😄 )
More important change: I've removed the alloc() in the context resampling, since swr_convert_frame allocates stuff itself here https://ffmpeg.org/doxygen/trunk/swresample__frame_8c_source.html more precisely, calculating itself the number of frame needed. Also fixed the flush()

Hope it makes sense 😄

@bacek
Copy link
Owner

bacek commented Mar 16, 2020

It should work with master branch of ffmpeg4-sys. I just can't release -sys crate because it's version is tied to ffmpeg, which is unfortunate.

@Polochon-street
Copy link
Author

Err, just cloning it gives

polochon@arch-coucou rust-ffmpeg4 $ cargo build --verbose --features "build"                       [0]
    Updating crates.io index
    Updating git repository `https://github.com/bacek/rust-ffmpeg4-sys`
error: no matching package named `ffmpeg4-sys` found
location searched: https://github.com/bacek/rust-ffmpeg4-sys
prerelease package needs to be specified explicitly
ffmpeg4-sys = { version = "4.3.0-pre.0" }
required by package `ffmpeg4 v0.4.0 (/home/polochon/rust-ffmpeg4)`

I guess master's travis build is passing because it has been built prior to the rust-ffmpeg4-sys bump?

.travis.yml Outdated Show resolved Hide resolved
@bacek
Copy link
Owner

bacek commented Mar 17, 2020 via email

@Polochon-street
Copy link
Author

@bacek I've updated stuff with your latest changes on ffmpeg4-sys, how does it look?
It passes on my machine, but hard to tell without the travis build 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants