-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flush resampling context #6
base: master
Are you sure you want to change the base?
Fix flush resampling context #6
Conversation
It should work with master branch of ffmpeg4-sys. I just can't release -sys crate because it's version is tied to ffmpeg, which is unfortunate. |
Err, just cloning it gives
I guess master's travis build is passing because it has been built prior to the rust-ffmpeg4-sys bump? |
Yes, it is.
…On Wed, Mar 18, 2020 at 8:39 AM Polochon-street ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#6 (comment)>:
> @@ -33,3 +33,4 @@ before_install:
script: |
travis_wait cargo build --verbose --features "build"
I guess cargo build --examples... should be enough? :)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFFELHQM7XKYW5H7V7HILRH7UXXANCNFSM4LDRRLYA>
.
--
Regards,
Vasily
|
11fe490
to
cb21a6c
Compare
cb21a6c
to
67a0982
Compare
@bacek I've updated stuff with your latest changes on |
Changed two things:
I saw rust-ffmpeg4-sys version was bumped, but it's still not working using
4.2.2
so just switched the branch to the stable version (it's failing anyways 😄 )More important change: I've removed the alloc() in the context resampling, since swr_convert_frame allocates stuff itself here https://ffmpeg.org/doxygen/trunk/swresample__frame_8c_source.html more precisely, calculating itself the number of frame needed. Also fixed the flush()
Hope it makes sense 😄