Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: testnet 5 documentation for Babylon validators #369
base: main
Are you sure you want to change the base?
docs: testnet 5 documentation for Babylon validators #369
Changes from 11 commits
0c9b468
fa80df0
72e3b67
12bf5c0
a652464
bbb9eed
f2d4734
0d86a88
a21af5e
f2a855b
25c8d75
17c63eb
931b9b5
43a0dc7
b9de762
9c5d79f
eaf6943
d3765c7
35145f8
c887828
b1ccfcf
0974f3b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we should explain that these settings will disable IAVL cache to make the node utilize less memory.
In case of a node that will serve heavy RPC query load, these settings shouldn't be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be step 2 given that the modifications on
app.toml
are step 1?We should point the user to the location where they are to find the seed node. This should be in the same repository, e.g.
../README.md
(see what we have for bbn-test-3)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this go to the validator guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm this should indeed be moved but I think we should include a modified version here to teach users how to create and manage keys, as its important for basic key management. Let's rename it from "Setup the required keys for operating a validator" to something more general like "Create Keys". ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this paragraph given that we have the above one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have a
Security
section at the bottom in which we provide important tips for security (in the validator document in which these paragraphs should be moved). You can consult @filippos47 for help on that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add the
--keyring-backend test
here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maiquanghiep we would if we are using keys no?