Improve code quality across multiple files #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `CancelAfterAsync` in `BackgroundQueue.cs` to use `CancelAsync` and improved `TimeoutException` message. - Modifie `ExecuteAsync` in `BackgroundQueueService.cs` to return immediately on cancellation exceptions. - Enhance `ExecuteTaskChunk` in `ConcurrentBackgroundQueueService.cs` to throw `InvalidOperationException` for null `TaskQueue`. - Change exception types in `CronJobServiceExtensions.cs` and `Account.cs` to `InvalidOperationException`. - Follow dispose pattern in `DelayedFileSystemWatcher.cs` and `CaptchaSvgGenerator.cs` and `CronJobService.cs` - Implement `IEqualityComparer` in `Angle` and `GermanHoliday` classes. - Refactor `Location.cs` for better readability. - Make classes `MaidenheadLocator`, `StringFormatter`, and `Constants` static - Update comments for clarity and removed redundant code.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CancelAfterAsyncinBackgroundQueue.csto useCancelAsyncand improvedTimeoutExceptionmessage.ExecuteAsyncinBackgroundQueueService.csto return immediately on cancellation exceptions.ExecuteTaskChunkinConcurrentBackgroundQueueService.csto throwInvalidOperationExceptionfor nullTaskQueue.CronJobServiceExtensions.csandAccount.cstoInvalidOperationException.DelayedFileSystemWatcher.csandCaptchaSvgGenerator.csandCronJobService.csIEqualityComparerinAngleandGermanHolidayclasses.Location.csfor better readability.MaidenheadLocator,StringFormatter, andConstantsstatic