Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility of html elements #201

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Oct 7, 2024

  • Replace anchor with button for Google Analytics opt-out link in Privacy.de.cshtml to enhance accessibility and user interaction.
  • Remove role="form" attribute from form elements in multiple .cshtml files to adhere to modern HTML5 standards.
  • Replace div with button for team filters in Fixtures.cshtml and Results.cshtml to improve accessibility and interaction.
  • Update Fixtures.cshtml to use asp-action and asp-controller attributes instead of inline JavaScript for printing match report sheets, enhancing maintainability and readability.
  • Added CSS rules in Fixtures.cshtml and Results.cshtml to style new button elements for team filters.

* Replace anchor with button for Google Analytics opt-out link in `Privacy.de.cshtml` to enhance accessibility and user interaction.
* Remove `role="form"` attribute from form elements in multiple `.cshtml` files to adhere to modern HTML5 standards.
* Replace `div` with `button` for team filters in `Fixtures.cshtml` and `Results.cshtml` to improve accessibility and interaction.
* Update `Fixtures.cshtml` to use `asp-action` and `asp-controller` attributes instead of inline JavaScript for printing match report sheets, enhancing maintainability and readability.
* Added CSS rules in `Fixtures.cshtml` and `Results.cshtml` to style new button elements for team filters.
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@axunonb axunonb merged commit c84023c into main Oct 7, 2024
3 of 4 checks passed
@axunonb axunonb deleted the pr/html-accessibility branch October 7, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant