Refactor HtmlToPdfConverter and update ReportSheetCache #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
axunonb
commented
Sep 29, 2024
axunonb
commented
- Move HtmlToPdfConverter to TournamentManager namespace
- Add detailed logging and error handling in HtmlToPdfConverter
- Add BrowserKind to set the kind of browser to use
- Add ability to create PDF from html content or a file
- Introduce DisplayMatchDate flag in ReportSheetCache
- Modify IsOutdated to check DisplayMatchDate flag
- Update Match constructor to include IServiceProvider
- Update ReportSheet action to use _serviceProvider for ReportSheetCache
- Updated ReportSheet.cshtml to conditionally display match date
- Add html {-webkit-print-color-adjust: exact;} CSS to ReportSheet.cshtml (enables colored output for PDF)
- Moved PuppeteerSharp package reference to TournamentManager.csproj
- Added localization for English and German
* Move HtmlToPdfConverter to TournamentManager namespace
* Add detailed logging and error handling in HtmlToPdfConverter
* Add BrowserKind to set the kind of browser to use
* Add ability to create PDF from html content or a file
* Introduce DisplayMatchDate flag in ReportSheetCache
* Modify IsOutdated to check DisplayMatchDate flag
* Update Match constructor to include IServiceProvider
* Update ReportSheet action to use _serviceProvider for ReportSheetCache
* Updated ReportSheet.cshtml to conditionally display match date
* Add html {-webkit-print-color-adjust: exact; } CSS to ReportSheet.cshtml (enables colored output for PDF)
* Moved PuppeteerSharp package reference to TournamentManager.csproj
* Added localization for English and German
axunonb
force-pushed
the
pr/html-to-pdf-converter
branch
from
3049025
to
4962469
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.