Refactor PDF generation using a new HtmlToPdfConverter #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated AppSettings.json to rename "Chromium" section to "Browser" for PDF generation. * Reflected this change across multiple files including ReportSheetCacheTests.cs, UnitTestHelpers.cs, and ReportSheetCache.cs. * Updated comments in ReportSheet.cshtml accordingly. * Simplified AppSettings.json by removing comments about `AllowedUserNameCharacters` and `DefaultLockoutTimeSpan` settings.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Refactor PDF generation * Updated README.md to reflect the correct Chromium version and added a note about rendering issues with Chromium 131.x. * Simplified the `EnsureCacheFolder` method in `ReportSheetCache.cs` by removing unnecessary directory existence checks and creation logic. * Added a new `HtmlToPdfConverter` class in `HtmlToPdfConverter.cs` to encapsulate the logic for converting HTML to PDF using either Puppeteer or a browser command line. * Refactored the `GetOrCreatePdf` method in `ReportSheetCache.cs` to use a new `HtmlToPdfConverter` class for generating PDF data, replacing the previous Puppeteer and browser command line logic. * Removed the `GetReportSheetBrowser`, `MovePdfToCache`, `GetReportSheetPuppeteer`, `CreateReportSheetPdfBrowser`, `CreateHtmlFile`, and `DeleteTempPathFolder` methods from `ReportSheetCache.cs` as they are now handled by the new `HtmlToPdfConverter` class. * Updated the `ReportSheet` action in `Match.cs` to use the new PDF generation logic. * Updated the Bootstrap CSS link in `ReportSheet.cshtml` to a newer version and adjusted the print styles accordingly.
axunonb
force-pushed
the
pr/browser-pdf-gen
branch
from
f6a260b
to
7ff7185
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "Chromium" to "Browser" in config and code
AllowedUserNameCharactersandDefaultLockoutTimeSpansettings.Refactor PDF generation
EnsureCacheFoldermethod inReportSheetCache.csby removing unnecessary directory existence checks and creation logic.HtmlToPdfConverterclass inHtmlToPdfConverter.csto encapsulate the logic for converting HTML to PDF using either Puppeteer or a browser command line.GetOrCreatePdfmethod inReportSheetCache.csto use a newHtmlToPdfConverterclass for generating PDF data, replacing the previous Puppeteer and browser command line logic.GetReportSheetBrowser,MovePdfToCache,GetReportSheetPuppeteer,CreateReportSheetPdfBrowser,CreateHtmlFile, andDeleteTempPathFoldermethods fromReportSheetCache.csas they are now handled by the newHtmlToPdfConverterclass.ReportSheetaction inMatch.csto use the new PDF generation logic.ReportSheet.cshtmlto a newer version and adjusted the print styles accordingly.