DrawNode calls: replacing Color4F with Color4B (without the 'test' folder!) #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but we may change underlaying color to vec4 in the future release |
The PR is for the current implementation. @halx99 will you accept this PR? |
|
both Color4F and Color4B is lgtm currently, I will merge it now, let me check |
halx99
approved these changes
Oct 1, 2024
xfbird
pushed a commit
to xfbird/axmol
that referenced
this pull request
Oct 12, 2024
…lder!) (axmolengine#2192) * drawNode calls: replace Color4F with Color4B * replace Color4F * removed unused includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Should be a small performance hub
See also axmol-1.0.0 Aug.9 2023:
[REFINE] Change DrawNode api color parameters from Color4F to low Color4BIssue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR