Cleanup private registry repositories after each successful test run #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eks-distro-bot
added
the
size/L
sp1999
force-pushed
the
cleanup-registry-repositories
branch
from
0466b60
to
6536eac
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8208 +/- ##
=======================================
Coverage 73.40% 73.40%
=======================================
Files 577 577
Lines 35900 35900
=======================================
Hits 26352 26352
Misses 7882 7882
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
|
/hold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, we had authenticated registry mirror tests failing consecutively due to
500 internal server error. On investigating further, I found out that the registry mirror had consumed it's full storage capacity of 200 GB so the tests weren't able to reach the server. In order to prevent this situation from arising in future, I have added a cleanup step in the registry mirror flow to remove all the repositories in the registry after every successful test run. If a test fails, the repositories will be kept to debug the issue further.Testing (if applicable):
make local-e2e
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.