Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set LD_LIBRARY_PATH when running sam init/sam build tests for nodejs20 #112

Merged
merged 11 commits into from
Nov 15, 2023
Merged

fix: set LD_LIBRARY_PATH when running sam init/sam build tests for nodejs20 #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
83b3c27
add arch specific targets
mndeveci Nov 15, 2023
b42c514
update test name temp
mndeveci Nov 15, 2023
dbb6dd3
update node executable with custom LD_LIBRARY_PATH
mndeveci Nov 15, 2023
32e771e
write new node exec with $ sign
mndeveci Nov 15, 2023
0f28035
remove redundant rm
mndeveci Nov 15, 2023
fe81fb9
revert nodejs20 dockerfile changes
mndeveci Nov 15, 2023
c60eaad
override ld_lib_path for tests
mndeveci Nov 15, 2023
e019af2
update environment
mndeveci Nov 15, 2023
f71fab1
add some comments
mndeveci Nov 15, 2023
0d8dafc
revert test class name change
mndeveci Nov 15, 2023
df491e4
remove additional makefile targets
mndeveci Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build-image-src/Dockerfile-nodejs20x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@ COPY ATTRIBUTION.txt /

# Compatible with initial base image
ENTRYPOINT []
CMD ["/bin/bash"]
CMD ["/bin/bash"]
28 changes: 20 additions & 8 deletions tests/build_image_base_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,26 @@ def test_sam_init(self):
if self.dep_manager:
sam_init += f" --dependency-manager {self.dep_manager}"

op = self.client.containers.run(
image=self.image,
command=[
"/bin/sh",
"-c",
sam_init + " && cd sam-app && sam build",
],
).decode()
# For nodejs20.x set LD_LIBRARY_PATH env variable to execute sam commands
if self.runtime == 'nodejs20.x':
op = self.client.containers.run(
image=self.image,
command=[
"/bin/sh",
"-c",
sam_init + " && cd sam-app && sam build",
],
environment=["LD_LIBRARY_PATH="]
).decode()
else:
op = self.client.containers.run(
image=self.image,
command=[
"/bin/sh",
"-c",
sam_init + " && cd sam-app && sam build",
],
).decode()
self.assertTrue(op.find("Build Succeeded"))

def test_external_apps(self):
Expand Down
Loading