Persist session #126
Open
Persist session #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sessions should be persisted throughout the connection. Also adds unique(ish) ids to each message.
|
@ulyssesp, as far as I can recall I did some experimenting at the time I was implementing the nREPL-VSCode communication part and couldn't figure out if the session ID is required. Have you ever faced the situation when absence of the ID made things go wrong? |
avli
force-pushed
the
master
branch
2 times, most recently
from
7e1c85a
to
068abc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sessions should be persisted throughout the connection. Also adds
unique(ish) ids to each message.
Disclaimer: no idea what I'm doing here, but this seems from nREPL docs that the session should persist over time.