Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reset timers feature #52

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add reset timers feature #52

wants to merge 4 commits into from

Conversation

z0ow
Copy link

@z0ow z0ow commented Jul 31, 2023 •
edited by avestura
Loading

name: Bug Report
about: Report a bug to the Eyes Guard community

Description

  1. Add a feature corresponding to issue Make a small suggestion.  #40
  2. Use App.Configuration.ProtectionState as a condition to raise the IdleChanged event, then remove the EnableRaisingEvents property. The past logic will make this event could not be triggered if the application starts with initialStart==false.
  3. Add a Chinese translation that is related to this feature.

PR Domain
Which change are you proposing?

Make users can prefer to reset short and long break timers by idle duration.

  • Add feature
  • Fix bug
  • Fix Typo
  • Extend support

Issue relation
This PR is related to issue #40

Screenshots
image

Additional context
[Add any other context about the problem here.]

@z0ow z0ow mentioned this pull request Jul 31, 2023
Open
@avestura
Copy link
Owner

avestura commented Aug 3, 2023

Thank you! And sorry for the delay, I'm pretty busy nowadays. I will review this as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@z0ow @avestura