Hotfix: Fix scoreboard check of index on base case

[20wildmanj]

#2092 introduced various error-checking mechanisms to prevent accidentally rendering bad scoreboard data. However, it introduced a bug where for assessments without column specifications that use the problem scores to populate the scoreboard, if the number of students on the scoreboard exceeds the number of problems, then further student submissions would show that their scoreboard entry errored, when in reality their scoreboard data is fine.

This PR removes the faulty check.

How Has This Been Tested?

1. Use the following autograded assessment with 1 problem:
   randomlab5_20240830.tar.zip

2. Submit submissions for at least 3 students

3. On master, see that there is a display error when viewing the scoreboard

4. On this branch, see that the error icon goes away and a score is displayed:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

[coderabbitai]

Walkthrough

Walkthrough

The change modifies a conditional check in a Ruby on Rails view template. It simplifies the logic that verifies whether grade[:entry] is an array, removing the length constraint that ensured there were enough elements in the array for iteration. This adjustment alters how the view handles the rendering of table rows based on the entries present.

Changes

File	Change Summary
app/views/scoreboards/show.html.erb	Modified conditional check to only verify if grade[:entry] is an array, removing the length constraint.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0e9c580 and 7a9e19f.

Files selected for processing (1)

• app/views/scoreboards/show.html.erb (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

[coder6583]

Looks good to me!

[KesterTan]

Should this line also be changed?

[20wildmanj]

Should this line also be changed?

No, that line is necessary for the case where there is a column specification but the number of specified columns is greater than the number of score entries.