Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete old results #34

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Delete old results #34

merged 2 commits into from
Oct 5, 2023

Conversation

Innixma
Copy link
Collaborator

@Innixma Innixma commented Oct 4, 2023

  • Delete old files / results
  • Add from_context as in paper
  • Add if tabular_predictions is not None check to support loading without pred probas (for single best simulation)

@Innixma Innixma requested a review from geoalgo October 4, 2023 19:09
Copy link
Collaborator

@geoalgo geoalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -294,6 +295,10 @@ def _construct_single_best_config_scorer(self, **kwargs) -> SingleBestConfigScor
)
return config_scorer

@classmethod
def from_context(cls, version: str = None, lazy_format: bool = True):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not load to keep the naming consistent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load already exists and is used in the case that you point to the directory of the artifacts (for lazy) or the pkl file (for in-memory), which is different from from_context.

@geoalgo geoalgo mentioned this pull request Oct 5, 2023
@Innixma Innixma merged commit 647c5bc into main Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants