Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Framework name fix #54

Merged
merged 7 commits into from
Sep 25, 2023

Conversation

prateekdesai04
Copy link
Contributor

@prateekdesai04 prateekdesai04 commented Sep 20, 2023

Description
A small change which is only applicable when there are multiple versions of AutoGluon frameworks in the cleaned and aggregated files.
If the dashboard is triggered by Benchmark tests then it will not perform filtering.
If the dashboard is run manually then filtering + formatting of framework names is not performed.
Eg: AutoGluon_good_1h_ag_bench_20230913T214333 will be reformatted to AutoGluon as before.
AutoGluon_master, AutoGluon_PR_1 will not be reformatted as these are from the benchmark tests.

Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: I think this renaming logic should resides in our CI/CD instead of dashboard. Dashboard should just draw whatever is being passed in. This way we keep dashboard more generalized

Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prateekdesai04 prateekdesai04 merged commit fb1809f into autogluon:main Sep 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants