Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fix custom scorer rmsle #166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

BUG: Fix custom scorer rmsle #166

wants to merge 1 commit into from
+2 −1

Conversation

AnirudhDagar
Copy link
Collaborator

@AnirudhDagar AnirudhDagar commented Nov 22, 2024 •
edited
Loading

Description

Fix value error for negative predictions by clipping negatives.

ValueError: Mean Squared Logarithmic Error cannot be used when targets contain negative values.

Also correct the scorer as optimum value will be 0 and not 1.

How Has This Been Tested?

  • Unit tests (pytest tests/)
  • Integration tests (if applicable)

Configuration Changes

  • No config changes
  • Config changes (please describe):

Type of Change

  • Bug fix
  • New feature
  • Documentation update
  • Performance improvement
  • Code cleanup/refactor

FANGAreNotGnu
FANGAreNotGnu approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@FANGAreNotGnu FANGAreNotGnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FANGAreNotGnu FANGAreNotGnu FANGAreNotGnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnirudhDagar @FANGAreNotGnu