CYGWIN: meson: support correct file extension for plugins.

[carlo-bramini]

CYGWIN uses shared libraries with .dll extension like Windows.
This patch fixes meson.build for setting PLUGIN_SUFFIX to the correct value for this platform.

[radioactiveman]

Hi @carlo-bramini,

Thanks for the contribution. Have you checked all the places where we use have_windows?
I am not familiar with Cygwin and wonder if it would not be better to use a check like below. Same applies for audacious-plugins.

have_windows = host_machine.system() in ['windows', 'cygwin']

[carlo-bramini]

Hi @carlo-bramini,

Thanks for the contribution. Have you checked all the places where we use have_windows?

I checked other places with references to have_windows into audacious-media-player and, in my opinion, other changes are not strictly required.
Actually, I found that only this line:

audacious/src/audacious/meson.build

Line 20 in 4a61c81

if have_windows

could be changed to:

if have_windows or have_cygwin

This change will add the RC file to the build process, although it is not required since the window manager will use audacious.desktop instead. However, it could be added if someone wants to see the icon and the properties of the executable also from Windows Explorer.

I am not familiar with Cygwin and wonder if it would not be better to use a check like below. Same applies for audacious-plugins.

have_windows = host_machine.system() in ['windows', 'cygwin']

I think that it would be better to leave the two environment separated.
Audacious on CYGWIN runs as a POSIX executable and it provides a different experience for the user, with the same feeling that you get when you use Audacious on UNIX.

There could be an exception, since CYGWIN has also a dedicated W32API version that integrates with the POSIX layer.
So, it is technically possible to mix features of Windows APIs with NEWLIB in POSIX application.
For example, I did another patch for the plugins which allows to enable waveout driver also with CYGWIN together with other typical drivers for UNIX, which is my favourite output driver when testing this platform.