Bump tree sitter #403
Merged
Bump tree sitter #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed the target branch so we have some buffer to fix the tests before the final merge. |
|
I cannot push to this branch. Could you enable push access? We need #4ffbf92aa |
|
Btw, you might've not seen this note from my pr:
I could update |
You meant, my branch on my repo, @aminya? If so, I just gave you access. |
|
@icecream17 What about merging it to our branch and then applying the changes on the repo we have access to? |
|
I made a new PR based on our branch: |
icecream17
added a commit
to icecream17/atom
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of atom-community#399 (atom-community@477b075) but where the packages that would've broke Atom are now updated Another link: atom-community#403 (comment)
icecream17
added a commit
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 3, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 9, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
aminya
pushed a commit
that referenced
this pull request
Jul 9, 2022
... previously v19 tree-sitter language packages. Continuation of #399 (477b075) but where the packages that would've broke Atom are now updated Another link: #403 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please, merge after this PR otherwise grammars will break: #399
This PR bumps tree-sitter to a recent version. It also uses "NPM's tree sitter", not an Atom/git specific one.
I know this code works with Electron 12. Unfortunately,
./script/bootstrapand friends do not work on my machine, so I have no way of testing if the "current way" of building Atom also works...Also, this PR is basically #386, but splitted into bumping tree-sitter. I'll open another bumping Electron (but it's also dependent on this one, unfortunately)