Use windows agent by default

[aminya]

To test azure pipeline

[DeeDeeG]

Pasting the error here for posterity:

A task is missing. The pipeline references a task called
'1ESLighthouseEng.PipelineArtifactCaching.RestoreCacheV1.RestoreCache'. This usually
indicates the task isn't installed, and you may be able to install it from the Marketplace:
https://marketplace.visualstudio.com. (Task version 1, job 'Windows', step ''.)

For the record, (as mentioned in #1) I think installing this artifact caching task thing to the atomcommunity Azure DevOps org should get rid of this error message.

[aminya]

I installed the after-mentioned package. Let's see

[DeeDeeG]

I got the same node-gyp rebuild error when building @atom/watcher. So I think that's a genuine bug with the Atom dependencies.

Probably the wrong V8 version/the wrong Node version or wrong Electron version, or something.

[aminya]

I got the same node-gyp rebuild error when building @atom/watcher. So I think that's a genuine bug with the Atom dependencies.

Probably the wrong V8 version/the wrong Node version or wrong Electron version, or something.

That seems strange. The upstream repo does not have this issue
https://github.visualstudio.com/9e67709c-1fe5-47f2-8cf6-4902878a11f5/_build/results?buildId=73864

We might have to install some other packages from the marketplace. Might be good to ask the upstream team instead.

[DeeDeeG]

The CI caches successful npm install results (node_modules) so maybe that's why.

---

Explanation/research:

I think there's an old @atom/watcher in [repo root]/package-lock.json. Leading to outdated nan which fails on some versions of Node 12. nodejs/nan#849 (comment) nodejs/nan#849 (comment)

This was fixed here: atom/watcher#234 (released in @atom/watcher v1.3.2+. Actually, there is no v1.3.2, so v1.3.3+ I guess?)

But [repo root]/package-lock.json still has an older version of @atom/watcher: https://github.com/atom/atom/blob/aa3c34bedb361e09a5068dce9620b460a20ca3fb/package-lock.json#L55 (v1.3.1).

I can even reproduce this failure on my local machine by running npm install in the repo root (atom/) dir under Node v12.18.2.

---

So I'm pretty sure it's an upstream Atom bug. Guess it's time to post an issue there... and if we get impatient we can patch it here.

[aminya]

In triggers > YAML > the default agent was Ubuntu. I noticed upstream is using Windows, while for us it is shown as Ubuntu.

It is a hosted agent:

Agent name: 'Hosted Agent'
Agent machine name: 'fv-az639'
Current agent version: '2.171.1'

https://github.visualstudio.com/Atom/_build/results?buildId=74130&view=logs&j=0d2f351d-5899-57e2-0cb5-b37eb91cc930&t=e687bea5-6de6-42f9-9697-c2cf69fb992a&l=2

[DeeDeeG]

Interesting. Well, checking out the git repo and doing npm install should work cross-platform. And then the later steps get run in their specified OSes. I think we can proceed trying to make this work in Ubuntu for now.

Edit: It got past the npm install step under Windows... I don't understand why... But it did. Maybe that missing V8 feature isn't used the same way on Linux as on Windows?

[aminya]

Interesting. Well, checking out the git repo and doing npm install should work cross-platform. And then the later steps get run in their specified OSes. I think we can proceed trying to make this work in Ubuntu for now.

Edit: It got past the npm install step under Windows... I don't understand why... But it did. Maybe that missing V8 feature isn't used the same way on Linux as on Windows?

That's something to consider for later. I guess it is more important to get this working first 😄

[DeeDeeG]

I found some docs for getting this to run automatically via closer GitHub integration, rather than just manually.

https://www.azuredevopslabs.com/labs/vstsextend/github-azurepipelines/#task-1-installing-azure-pipelines-from-github-marketplace

I'm not 100% sure but it looks like you may have done part or all of this already.

[DeeDeeG]

I found the main Azure docs, but there's a lot of them:

• https://docs.microsoft.com/azure/devops/
• https://docs.microsoft.com/azure/devops/pipelines/
• https://docs.microsoft.com/azure/devops/pipelines/create-first-pipeline
• https://docs.microsoft.com/azure/devops-project/azure-devops-project-github

[DeeDeeG]

This has to be the docs we're looking for: https://docs.microsoft.com/azure/devops/pipelines/repos/github

[DeeDeeG]

I figured out why it works in Windows and not Ubuntu.

There are lines like this, with backslashes in some paths:

cd script\vsts

The backslash is treated as an escape character on Ubuntu/macOS, so the cd doesn't happen:

sh: line 1: cd: scriptvsts: No such file or directory

Changing the backslashes to forward-slashes also works, as an alternative to forcing Windows.
https://dev.azure.com/DeeDeeG/b/_build/results?buildId=44&view=logs&j=0d2f351d-5899-57e2-0cb5-b37eb91cc930&t=4bcffbf6-507a-564a-0cc4-d6754c0b024f

(^ This is a successful run of the GetReleaseVersion job, on Ubuntu 16.04.)

I'd like to post an issue/maybe a PR at upstream about this.

[aminya]

@DeeDeeG Awesome! One you made the PR we can merge it here.

[DeeDeeG]

Whoops, I just saw your comment. Yeah, trying to get this accepted upstream.

Issue: atom#21020

PR: atom#21021