-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload Bootstrapped Repository #10
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This gets uploaded to Azure artifacts. How do we upload it to the release page of GitHub? |
With the GitHub API I think. Making a correct HTTP POST to the API some way or other. https://docs.github.com/en/rest/reference/repos#upload-a-release-asset Edit:
|
It seems we already have the scripts needed for releasing. We just need to test and try it to see if we need to add some variables or tokens. |
We can probably reuse the bootstrapped repository in other jobs. Now MacOS bootstraps atom 4 times in total! (each being ~10min). We can reduce this time by uploading and downloading it. One reason for Windows tests failing is that all the tests run at once in one machine which stops responding properly. If we reuse the bootstrapped repo, we can speed up the CI. There is probably a better way. We might just cache the repository for the next job. This is easy in GitHub actions and should be possible in Azure too. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
0247565
to
adaefd5
Compare
This comment has been minimized.
This comment has been minimized.
I want to merge this eventually (only on release builds). We can release bootstrapped repositories with our binaries. |
0f34404
to
52de343
Compare
35c3926
to
b24b99a
Compare
87c664d
to
67dcaef
Compare
d5b2b31
to
1808785
Compare
6ac9981
to
b7e3fe1
Compare
b7e3fe1
to
8d45f3f
Compare
As you can see most checks did not pass |
to provide a ready development environment (similar to a pre-built docker image) Only uploaded the release job
Benchmarks: total size: 1.74 GB method/time/final_size ultra 2:19 494MB maximum 1:52 511MB normal 1:12 528MB fast 0:40 604MB fastest 0:32 658MB
This shows if we are running the build job or the test job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest finding anything wrong because tests are not passing.
Description of the change
This adds a step to the release CI that uploads the ready bootstrapped repository. This provides a ready development environment for people to start hacking Atom's Core without running and dealing with the bootstrap script (similar to a pre-built docker images).
Verification
The CI passes