This repository has been archived by the owner on Nov 29, 2023. It is now read-only.
Use void pointers instead of C++ object pointers. #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
void *
instead of QWhatever pointers in function return types. This is consistent with how we treat C++ objects -- as opaque pointers -- and will probably cause less errors on the side of the testing/application C/Lisp code.All the C++ idioms in
main()
ofinterface.cpp
are replaced with equivalent C code. This required writing a new function (newEmptyKeyPressFilter()
, namely). Should there be a Lisp binding for it? Doesn't look really useful.It's fully compatible with the existing Lisp-side code. Compiles, runs (I was able to test the C version only, so not sure about the CL one).
How does it look to you?