Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update @asyncapi/parser to 2.1.0 #151

Merged
merged 2 commits into from
Oct 23, 2023
Merged

chore: update @asyncapi/parser to 2.1.0 #151

merged 2 commits into from
Oct 23, 2023

Conversation

aayushmau5
Copy link
Member

@aayushmau5 aayushmau5 commented May 29, 2023 •
edited
Loading

Description

  • This PR updates @asyncapi/parser dev dependency to version ^2.1.0.
  • Jest version to ^29.5.0

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aayushmau5
Copy link
Member Author

aayushmau5 commented May 29, 2023 •
edited
Loading

https://github.com/asyncapi/diff/actions/runs/5108591475/jobs/9182547896?pr=151#step:10:13

The job fails with this error. Not sure what's the problem? Is there any dependency missing?

cc @derberg

@aayushmau5 aayushmau5 changed the title feat: update @asyncapi/parser to 2.0.0 chore: update @asyncapi/parser to 2.0.0 Jun 2, 2023
@aayushmau5 aayushmau5 mentioned this pull request Jun 2, 2023
Closed
derberg
derberg previously approved these changes Jun 21, 2023
View reviewed changes
derberg
derberg reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fail but I think it is not because of your PR but because of #152

@aayushmau5 aayushmau5 closed this Aug 28, 2023
@aayushmau5 aayushmau5 reopened this Aug 28, 2023
@aayushmau5
Copy link
Member Author

@jonaslagoni can you help with this? I don't think its because of #152, since all the workflows are managed by asyncapi/.github repo.

@jonaslagoni
Copy link
Member

@aayushmau5 it's because you use an old version of node/npm (v14 I think) in v16 and above this problem with ajv not being found has been fixed.

But if you are upgrading node + #152 I would go straight to v18 🙂

@aayushmau5
Copy link
Member Author

image
locally, i'm getting the same error. Node v18.

@aayushmau5 aayushmau5 changed the title chore: update @asyncapi/parser to 2.0.0 chore: update @asyncapi/parser to 2.1.0 Sep 1, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@aayushmau5
Copy link
Member Author

/rtm

@asyncapi-bot asyncapi-bot merged commit 1030ee4 into asyncapi:master Oct 23, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derberg derberg derberg approved these changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo vinitshahdeo is a code owner

@onbit-uchenik onbit-uchenik Awaiting requested review from onbit-uchenik onbit-uchenik is a code owner

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aayushmau5 @jonaslagoni @derberg @asyncapi-bot