Custom desc + test drying #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstonematt
force-pushed
the
custom-desc
branch
from
b26cd0c
to
a3261dd
Compare
SEJeff
approved these changes
Oct 24, 2024
| {Name: "solana_account_balance", ExpectedResponse: balanceMetricResponse}, | ||
| collector.NodeVersion.makeCollectionTest(NewLV(1, "1.16.7")), | ||
| collector.NodeIsHealthy.makeCollectionTest(NewLV(1, identity)), | ||
| collector.NodeNumSlotsBehind.makeCollectionTest(NewLV(0, identity)), |
There was a problem hiding this comment.
I liked the previous tests, mainly because it is so much more obvious to the test reader what you're asserting where here it isn't, but understand why you did it.
There was a problem hiding this comment.
I do agree that this is more cryptic, but was just very awkward to maintain imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to update the tests after renaming the metrics in #57 was a pain, this makes it easier in future. And just generally makes tests easier to write imo.