Quantity basics #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
force-pushed
the
quantity-basics
branch
from
406df6c
to
c89827e
Compare
nstarman
reviewed
Nov 18, 2024
|
|
||
| @property | ||
| def __array_namespace__(self): | ||
| # TODO: make our own? |
There was a problem hiding this comment.
I think eventually, but not urgently.
| return np | ||
|
|
||
| def __getitem__(self, item): | ||
| return self.__class__(self.value.__getitem__(item), self.unit) |
There was a problem hiding this comment.
Not sure about the comparative speed, but using dataclasses.replace works better for subclasses, e.g. Angle, which have additional attributes.
Suggested change
| return self.__class__(self.value.__getitem__(item), self.unit) | |
| return replace(self, value=self.value.__getitem__(item)) |
quantity/core.py
Outdated
Comment on lines
140
to
143
| try: | ||
| xp = self.value.__array_namespace__() | ||
| except AttributeError: | ||
| xp = np |
There was a problem hiding this comment.
what about defining a __value_array_namespace__ that does this?
def __value_array_namespace__(self):
try:
xp = self.value.__array_namespace__()
except AttributeError:
xp = np
return xp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for
numpy,array-api-strict,dask, andjax, with basic tests for all, and ufuncs fornumpyonly. Pushing now in part to check whether CI works properly.