ImageFileCollection fails if the fits headers contain the keyword 'FILE' #726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an assert statement on line 503 in image_collection.py in method _dict_from_fits_header:
assert 'file' not in h
to catch and raise the problem - but no handling is implemented.
If not caught the 'file' value list in the summary dictionary would get a filename appended twice for each image.
This will cause the generation of the summary_table to fail.
The suggested way to fix this is to remove the header 'FILE' keyword if present.
This should be okay since it will either be the same as the input filename or likely incorrect - I guess?
Please have a look at the following list and replace the "[ ]" with a "[x]" if
the answer to this question is yes.
For documentation changes:
Note that it should not if you changed any examples!
For bugfixes:
For new functionality:
Please note that the last point is not a requirement. It is meant as a check if
the pull request potentially breaks backwards-compatibility.