Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of utility C code for less duplication #76

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

cmccully
Copy link
Contributor

There was a lot of code duplication in the C code for medianing and dilating images. I have removed as much as possible in hopes of making it easier to update how edges are handled in the future as discussed in #38 . Note this is expected to be merged after #74.

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #76 (0f2f955) into main (783f217) will increase coverage by 2.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   93.09%   95.09%   +2.00%     
==========================================
  Files           7        6       -1     
  Lines         782      836      +54     
  Branches       12        0      -12     
==========================================
+ Hits          728      795      +67     
+ Misses         54       41      -13     
Impacted Files Coverage Δ
astroscrappy/utils/median_utils.pyx 100.00% <ø> (ø)
astroscrappy/astroscrappy.pyx 83.53% <100.00%> (+5.84%) ⬆️
astroscrappy/utils/image_utils.pyx 100.00% <100.00%> (ø)
astroscrappy/utils/imutils.c 100.00% <100.00%> (ø)
astroscrappy/utils/medutils.c 100.00% <100.00%> (ø)
astroscrappy/__init__.py

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@saimn
Copy link
Contributor

saimn commented Dec 7, 2023

@cmccully - Could you rebase now that #74 and #81 are merged ? You will have a few conflicts to resolve I guess...
Also Cython 3.0 has been released :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants