Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaia: update the output file name built by the method load_data to include microsecond resolution #3130

Merged

Conversation

cosmoJFH
Copy link
Contributor

@cosmoJFH cosmoJFH commented Nov 9, 2024

In #3128 describes the requirement to include the microsecond resolution in the output file name built by the method load_data.

Units tests were updated.

cc @esdc-esac-esa-int

jira: GAIAPCR-1331

Copy link

codecov bot commented Nov 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.53%. Comparing base (58f8692) to head (ce16157).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/gaia/core.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3130      +/-   ##
==========================================
+ Coverage   67.49%   67.53%   +0.04%     
==========================================
  Files         233      233              
  Lines       18413    18487      +74     
==========================================
+ Hits        12428    12486      +58     
- Misses       5985     6001      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bsipocz bsipocz added the gaia label Nov 11, 2024
@bsipocz bsipocz added this to the v0.4.8 milestone Nov 11, 2024
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cosmoJFH, this all looks good to me. I'll leave a changelog label as a reminder for the release time to consolidate the entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants