-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Mm/uq app #337
Open
mmcleod89
wants to merge
36
commits into
development
Choose a base branch
from
mm/uq_app
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Mm/uq app #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Now depends on the sopt onnx_tweaks pull request being merged before it will work. Also does some refactors to where information is found relating to the types of the functions f and g |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
main
and into separate functions so that they can be shared with UQCurrently needs
algo_factory
test case. This is so there's something I can run this with and check that the app is doing something sensible in lieu of a purify config file but it should be taken out later.Issues
Replacing the line:
const VectorC wavelet_rep = wavelet_operator->adjoint() * image;
in UQ with
const auto wavelet_rep = wavelet_operator->adjoint() * image;
causes a seg-fault, although I don't know why yet. The inferred type of
wavelet_rep
isAppliedFunction
, and in the next line when we call the sum and things are evaluated we get a seg-fault.