Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Conan for installing dependencies #302

Merged
merged 97 commits into from
Aug 15, 2023
Merged

Use Conan for installing dependencies #302

merged 97 commits into from
Aug 15, 2023

Conversation

SJaffa
Copy link
Contributor

@SJaffa SJaffa commented Feb 24, 2022

Starting from the development branch, first issue was the same spdlog error as in sopt

  • Update install instructions in README.md with Use Conan for installing dependencies #302 (comment)
  • Fix code errors in algo_factory.h
  • Only include sopt TF headers from algo_factory.h when cppflow==on option is passed to cmake
  • In sopt, move class GProximal to the sopt::algorithm namespace
  • Update documentation GitHub Actions workflow

@SJaffa SJaffa self-assigned this Feb 24, 2022
@SJaffa SJaffa linked an issue Feb 24, 2022 that may be closed by this pull request
@SJaffa
Copy link
Contributor Author

SJaffa commented Apr 1, 2022

  • Checks fail
    • All Ubuntu fails in build step because of spdlog error in SOPT, need to pull SOPT to fix this
    • macOS clang also fails in build step because of spdlog error
    • macOS gcc fails in 'install conan on gcc'
      • boost fiber error:

boost/1.78.0: WARN: Boost component 'fiber' is missing libraries. Try building boost with '-o boost:without_fiber'. (Option is not guaranteed to exist) ERROR: boost/1.78.0: Error in package_info() method, line 1592 raise ConanException("These libraries were expected to be built, but were not built: {}".format(non_built)) ConanException: These libraries were expected to be built, but were not built: {'boost_fiber'}

@tkoskela
Copy link
Contributor

tkoskela commented Jun 8, 2022

We need to close astro-informatics/sopt#279 before we can make progress with this

- How do we build the sopt package automatically? Right now it points
to my private test version of the package.
- tests/measurement_operator.cc had some lines with semicolons missing!
- in tests/mpi_algo_factory.cc I had to comment out statements with
CAPTURE(uv_data.vis.head(5)); because something was going wrong with
the macro expansion.
- the mpi_algo_factory test only passes when the number of processes
is 2. Otherwise it seems to hang indefinitely. There is a lot of code
around world.size == 2.
tkoskela and others added 5 commits July 12, 2023 16:57
Following the pattern of other flags in this file; PURIFY_CPPFLOW doens't get set properly without this line, I think it is otherwise not defined.
@mmcleod89
Copy link
Contributor

Looking at things here I think that this is up to date now with what I expect, keeping the forward-backward tensorflow test out of it for a separate PR. 👍

@tkoskela
Copy link
Contributor

Ok, from my point of view the only outstanding item is updating the documentation workflow. I think everything else looks good to go.

This was linked to issues Jul 21, 2023
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@SJaffa SJaffa requested a review from tkoskela July 21, 2023 16:37
@SJaffa
Copy link
Contributor Author

SJaffa commented Jul 21, 2023

I've checked the installation instructions in the readme work for me from a clean setup, I've updated the documentation workflow (although not tested this as it only runs when we push to development branch) and the other couple of outdated bits in the readme I've made new issues as they can be solved separately. So if someone could check over the docs workflow I think this is finally ready to merge! (assuming the tests pass...)

Copy link
Contributor

@mmcleod89 mmcleod89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ code is good for me; as far as the docs action goes it looks okay to me but I don't think it's possible to run it manually so I'm happy for there to be a separate issue if there needs to be a further tweak there rather than extending this PR any further.

@mmcleod89 mmcleod89 dismissed tkoskela’s stale review August 15, 2023 12:45

All conversations from the review have now been marked resolved and TK has said he's happy to merge.

@mmcleod89 mmcleod89 merged commit 2fc72bd into development Aug 15, 2023
@tkoskela tkoskela deleted the sj/conan-build branch September 18, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants