Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mm/uq app #337

Open
wants to merge 36 commits into
base: development
Choose a base branch
from
Open

WIP: Mm/uq app #337

wants to merge 36 commits into from

Conversation

mmcleod89
Copy link
Contributor

Changes

  • Add UQ executable to cmake
  • Refactors various setup steps out of purify main and into separate functions so that they can be shared with UQ
  • Calculates likelihood / prior terms assuming they are L2 and L1 norms (will need update when pytorch models are in place)

Currently needs

  • I think sigma can be derived from the purify config parameters so that should be updated
  • We need some purify config files to test the UQ and purify apps with to make sure nothing is breaking
  • There are two paths for the setup, one using a purify config file and one based on the algo_factory test case. This is so there's something I can run this with and check that the app is doing something sensible in lieu of a purify config file but it should be taken out later.
  • Some appropriate tests need to be devised.

Issues
Replacing the line:
const VectorC wavelet_rep = wavelet_operator->adjoint() * image;
in UQ with
const auto wavelet_rep = wavelet_operator->adjoint() * image;
causes a seg-fault, although I don't know why yet. The inferred type of wavelet_rep is AppliedFunction, and in the next line when we call the sum and things are evaluated we get a seg-fault.

@tkoskela tkoskela linked an issue Oct 3, 2024 that may be closed by this pull request
6 tasks
@mmcleod89
Copy link
Contributor Author

Now depends on the sopt onnx_tweaks pull request being merged before it will work.

Also does some refactors to where information is found relating to the types of the functions f and g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write Initial UQ Application
1 participant