Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default to "latest" #37

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Change default to "latest" #37

merged 2 commits into from
Sep 5, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Also did some light editing of the README.

@charliermarsh
Copy link
Member Author

@eifinger -- Anything else that I'm missing here?

README.md Show resolved Hide resolved
@henryiii
Copy link

henryiii commented Sep 5, 2024

Does this do less caching? From what I understood, using a fixed version would cache uv. Before it was fixed based on the version of this action?

Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. It was missing to remove the "automatic" default version upgrade but I think that is better placed in a separate PR: #39

We should also clearly communicate this breaking change in the release note for existing users of this action. (added the breaking-change label to this PR)

README.md Outdated Show resolved Hide resolved
@eifinger
Copy link
Collaborator

eifinger commented Sep 5, 2024

Does this do less caching? From what I understood, using a fixed version would cache uv. Before it was fixed based on the version of this action?

Yes, but only for self-hosted runners. See the added note in the readme:
image
https://github.com/astral-sh/setup-uv/pull/37/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R38-R40

On GitHub hosted runners we always download uv since there is no persistent TOOL_CACHE.

Base automatically changed from charlie/prettier to main September 5, 2024 12:06
@charliermarsh
Copy link
Member Author

I think we can also do a bit more work to improve the caching if it's impactful for self-hosted users (it's still <1s on GitHub Runners as-is): #45

@zanieb
Copy link
Member

zanieb commented Sep 5, 2024

When we release this, should it be as v2?

@charliermarsh
Copy link
Member Author

Works for me!

Co-authored-by: Kevin Stillhammer <[email protected]>
@charliermarsh charliermarsh merged commit bfebbf8 into main Sep 5, 2024
38 checks passed
@charliermarsh charliermarsh deleted the charlie/latest branch September 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants