-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default to "latest"
#37
Conversation
@eifinger -- Anything else that I'm missing here? |
daf0ec2
to
ed79b28
Compare
d8137d8
to
cd267d1
Compare
c451d90
to
4d52f78
Compare
Does this do less caching? From what I understood, using a fixed version would cache uv. Before it was fixed based on the version of this action? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good. It was missing to remove the "automatic" default version upgrade but I think that is better placed in a separate PR: #39
We should also clearly communicate this breaking change in the release note for existing users of this action. (added the breaking-change label to this PR)
Yes, but only for self-hosted runners. See the added note in the readme: On GitHub hosted runners we always download uv since there is no persistent |
I think we can also do a bit more work to improve the caching if it's impactful for self-hosted users (it's still <1s on GitHub Runners as-is): #45 |
When we release this, should it be as v2? |
Works for me! |
5df5fcb
to
3e77235
Compare
Co-authored-by: Kevin Stillhammer <[email protected]>
Summary
Also did some light editing of the README.