Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change release notes to encourage bzlmod #735

Merged
merged 1 commit into from
Nov 13, 2024
Merged

docs: change release notes to encourage bzlmod #735

merged 1 commit into from
Nov 13, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Nov 7, 2024

The previous wording "with Bazel 6" is outdated and makes that option appear to be the "legacy old bazel 6" snippet.

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Nov 7, 2024 •
edited
Loading

Test

All tests were cache hits

149 tests (100.0%) were fully cached saving 9s.

Buildifier      Format

alexeagle
alexeagle approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd like all of ours to be downstream of whatever the rules-template creates

@jbedard jbedard merged commit 981c505 into aspect-build:main Nov 13, 2024
24 checks passed
@jbedard jbedard deleted the release-notes-bzlmod branch November 13, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @alexeagle