Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support setting resolveJsonModule with inline ts_project(tsconfig) #728

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 31, 2024

I noticed resolveJsonModule is treated different then all the other tsconfig attributes which must be aligned between the macro and tsconfig where you can't depend on the tsconfig dict. This allows setting the value only in the tsconfig dict like any other compiler option.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Oct 31, 2024

Test

4 test targets passed

Targets
//examples/resolve_json_module:ts-dict-override_typecheck_test [k8-fastbuild]    103ms
//examples/resolve_json_module:ts-dict-unspecified_typecheck_test [k8-fastbuild] 33ms
//examples/resolve_json_module:ts-with-json-dict-override [k8-fastbuild]         81ms
//examples/resolve_json_module:ts-with-json-dict-unspecified [k8-fastbuild]      139ms

Total test execution time was 356ms. 142 tests (97.3%) were fully cached saving 8s.


Buildifier      Format

@jbedard jbedard force-pushed the tsconfig-resolve_json branch 2 times, most recently from 508f9f3 to fcfd554 Compare October 31, 2024 04:58
ts/defs.bzl Outdated Show resolved Hide resolved
ts/defs.bzl Show resolved Hide resolved
@jbedard jbedard merged commit 3849ce6 into aspect-build:main Oct 31, 2024
24 checks passed
@jbedard jbedard deleted the tsconfig-resolve_json branch October 31, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants