Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] : sign-in #18

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[FEATURE] : sign-in #18

wants to merge 2 commits into from

Conversation

kornkanokwell
Copy link
Collaborator

No description provided.

nutthanonn
nutthanonn reviewed Apr 27, 2024
View reviewed changes
src/auth/auth.service.ts Outdated Show resolved Hide resolved
src/auth/auth.controller.ts Outdated Show resolved Hide resolved
src/auth/auth.service.ts Outdated Show resolved Hide resolved
src/auth/auth.controller.ts Outdated Show resolved Hide resolved
famesensor
famesensor requested changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@famesensor famesensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refresh token use uuid and insert this to database

src/auth/auth.controller.spec.ts Outdated Show resolved Hide resolved
src/auth/auth.module.ts Outdated Show resolved Hide resolved
src/auth/auth.service.spec.ts Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

src/auth/auth.service.ts Outdated Show resolved Hide resolved
src/auth/dto/create-auth.dto.ts Outdated Show resolved Hide resolved
famesensor
famesensor requested changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@famesensor famesensor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • move src/auth to src/modules/auth kub
  • script migrate table ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nutthanonn nutthanonn nutthanonn left review comments

@famesensor famesensor famesensor requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kornkanokwell @famesensor @nutthanonn