[FEATURE]: Home Page #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spectrum862
requested changes
May 21, 2024
There was a problem hiding this comment.
remove this lock file. use pnpm instend of npm.
There was a problem hiding this comment.
shoud it be image from backend?.
There was a problem hiding this comment.
use png for image and svg for icon. move all asset to public/images
| import { ReactElement } from 'react' | ||
| import NewsCard from './newsCard' | ||
|
|
||
| export default function Achivements(): ReactElement { |
There was a problem hiding this comment.
use arrow function and it type NextPage
Comment on lines
+18
to
+20
| <NewsCard /> | ||
| <NewsCard /> | ||
| <NewsCard /> |
There was a problem hiding this comment.
make it render from data
Comment on lines
+18
to
+20
| return ( | ||
| <Container> | ||
| <Card sx={{ maxWidth: 378 }}> |
Comment on lines
+7
to
+15
| const Container = styled('div')` | ||
| && { | ||
| padding: 20px; | ||
| text-align: center; | ||
| } | ||
| ` | ||
| const Space = styled('div')` | ||
| && { | ||
| padding-bottom: 50px; |
There was a problem hiding this comment.
use native Mui component
Comment on lines
+23
to
+30
| <Grid item xs={12} sm={6} md={4}> | ||
| <WorkCard /> | ||
| </Grid> | ||
| <Grid item xs={12} sm={6} md={4}> | ||
| <WorkCard /> | ||
| </Grid> | ||
| <Grid item xs={12} sm={6} md={4}> | ||
| <WorkCard /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create component and mock-up data in homepage