Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Change Password Page #11

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

Jenesix
Copy link
Collaborator

@Jenesix Jenesix commented Apr 12, 2024

No description provided.

@Jenesix Jenesix self-assigned this Apr 12, 2024
confirmPassword: string
}

const FgPassword: React.FC = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename -> ForgotPasswordPage

confirmPassword: '',
})

const handleChange = (e: ChangeEvent<HTMLInputElement>) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add return type

confirmPassword: string
}

const FgPassword: React.FC = () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to container

return (
<>
<Head>
<title>Create Next App</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use only necessary

gap: 2,
}}
>
<TextField
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font in TextField in correct

>
<Box
component="article"
sx={{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use inline use Stack

variant="contained"
color="primary"
size="large"
sx={{ mt: 2, width: '30%' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use absolute width, or min max width

variant="outlined"
color="primary"
type="password"
value={data.confirmPassword}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont control change and value give form control it

import React, { ChangeEvent, FormEvent, useState } from 'react'
import Logo from '../../../public/Images/ACSlogo.svg'

type FormState = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to ForgetForm

<link rel="icon" href="/favicon.ico" />
</Head>
<Box
component="main"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to main layout

@famesensor famesensor changed the title feat: change password page [FEATURE]: Change Password Page Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants