-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE]: Change Password Page #11
base: develop
Are you sure you want to change the base?
Conversation
src/pages/password_change/index.tsx
Outdated
confirmPassword: string | ||
} | ||
|
||
const FgPassword: React.FC = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename -> ForgotPasswordPage
src/pages/password_change/index.tsx
Outdated
confirmPassword: '', | ||
}) | ||
|
||
const handleChange = (e: ChangeEvent<HTMLInputElement>) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add return type
src/pages/password_change/index.tsx
Outdated
confirmPassword: string | ||
} | ||
|
||
const FgPassword: React.FC = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move to container
src/pages/password_change/index.tsx
Outdated
return ( | ||
<> | ||
<Head> | ||
<title>Create Next App</title> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use only necessary
src/pages/password_change/index.tsx
Outdated
gap: 2, | ||
}} | ||
> | ||
<TextField |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font in TextField in correct
src/pages/password_change/index.tsx
Outdated
> | ||
<Box | ||
component="article" | ||
sx={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont use inline use Stack
src/pages/password_change/index.tsx
Outdated
variant="contained" | ||
color="primary" | ||
size="large" | ||
sx={{ mt: 2, width: '30%' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use absolute width, or min max width
src/pages/password_change/index.tsx
Outdated
variant="outlined" | ||
color="primary" | ||
type="password" | ||
value={data.confirmPassword} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont control change and value give form control it
src/pages/password_change/index.tsx
Outdated
import React, { ChangeEvent, FormEvent, useState } from 'react' | ||
import Logo from '../../../public/Images/ACSlogo.svg' | ||
|
||
type FormState = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename to ForgetForm
src/pages/password_change/index.tsx
Outdated
<link rel="icon" href="/favicon.ico" /> | ||
</Head> | ||
<Box | ||
component="main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to main layout
No description provided.