Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gitpod config, Update node version, Update some dependencies, Reduce logo size and Add github actions #176

Open
wants to merge 58 commits into
base: master
Choose a base branch
from

Conversation

chintan9
Copy link

@chintan9 chintan9 commented Jan 8, 2020

Add Gitpod config, Update node version, Update some dependencies, Reduce logo size and Add github actions


This change is Reviewable

dependabot-support and others added 30 commits December 20, 2017 17:20
…edep-approx-3.0.1

Update grunt-wiredep requirement to ~3.0.1
…ntomjs-launcher-approx-1.0.4

Update karma-phantomjs-launcher requirement to ~1.0.4
…er-approx-1.3.0

Update grunt-newer requirement to ~1.3.0
…-tw-2.0.4

Update socket.io requirement to ^2.0.4
…trib-cssmin-approx-2.2.1

Update grunt-contrib-cssmin requirement to ~2.2.1
…trib-jshint-approx-1.1.0

Update grunt-contrib-jshint requirement to ~1.1.0
…trib-htmlmin-approx-2.4.0

Update grunt-contrib-htmlmin requirement to ~2.4.0
…t-tasks-approx-3.5.2

Update load-grunt-tasks requirement to ~3.5.2
…tw-4.16.3

Update express requirement to ^4.16.3
…ntrib-watch-approx-1.0.1

Update grunt-contrib-watch requirement to ~1.0.1
*Total -- 33.36kb -> 15.71kb (52.9%)

/app/images/logo.png -- 31.64kb -> 14.38kb (54.57%)
/app/images/logo.svg -- 1.71kb -> 1.33kb (22.15%)

Signed-off-by: ImgBotApp <[email protected]>
…smine-3.0.1

Bump karma-jasmine from 0.1.6 to 3.0.1
[ImgBot] Optimize images
[pull] master from asapach:master
@chintan9 chintan9 changed the title Add Gitpod config Add Gitpod config & update node version Jan 8, 2020
chintan9 and others added 15 commits January 8, 2020 16:37
…ntrib-watch-approx-1.1.0

Update grunt-contrib-watch requirement to ~1.1.0
…ntrib-htmlmin-approx-3.1.0

Update grunt-contrib-htmlmin requirement from ~2.4.0 to ~3.1.0
…rma-tw-3.0.0

Update grunt-karma requirement from ^2.0.0 to ^3.0.0
…ntrib-uglify-approx-4.0.1

Update grunt-contrib-uglify requirement from ~0.4.0 to ~4.0.1
…ntrib-cssmin-approx-3.0.0

Update grunt-contrib-cssmin requirement from ~2.2.1 to ~3.0.0
@chintan9 chintan9 changed the title Add Gitpod config & update node version Add Gitpod config, Update node version, Update some dependencies, Reduce logo size and Add github actions Jan 8, 2020
@au5ton
Copy link

au5ton commented Feb 26, 2020

boop @asapach

@asapach
Copy link
Owner

asapach commented Feb 26, 2020

What's Gitpod and why should it be so prominently mentioned on the home page? I'm afraid that out of the 58 commits in this PR only a couple would make sense

@pataquets
Copy link

Skimming the commit log, I see some worthwhile changes, mainly dependencies upgrading.
For the Gitpod concern, I've checked it and I think it won't hurt to have the button available, IMHO. It would ease contributing, which is always good. However, I agree on the fact that's too prominently placed, with no reason. Maybe placing it somewhere else, such as in the development markdown file would be a better place and would make more sense.
@asapach If it makes sense to you, maybe @chintan9 can push a commit moving it. I checked out the Github 'network graph' and @chintan9 's fork has lots of commits which surely would be worthwhile to consider. What do you think?

@asapach
Copy link
Owner

asapach commented Mar 28, 2020

Most of these changes are low hanging fruit, and can now be mostly automated using GitHub bots, so this PR of little value. However if somebody wants to create a new PR with a cleaner history, without bells and whistles, they are welcome.

@pataquets
Copy link

Are the changes good enough as they are? I mean, would just a squash be enough?
I could give a stab at it, if they are. Unless @chintan9 beats me at it :) I would like the credit going to the OP.

@asapach
Copy link
Owner

asapach commented Mar 29, 2020

You could cherry-pick the changes to package.json (+ package-lock.json) and .travis.yml, the rest are irrelevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants