Added common basic test cases for cache4k #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sujin1135
force-pushed
the
test/added-cache4k-testcases
branch
from
01352a3
to
dfdfd56
Compare
Sujin1135
force-pushed
the
test/added-cache4k-testcases
branch
from
dfdfd56
to
02a144a
Compare
|
Sorry for taking so long to merge this. It's wonderful to have people contributing test cases to ensure that we don't break things when moving forward :) |
|
@serras Thank you for merging and leaving a comment:) and... Could you let me know how to join this Slack channel? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that cache4k does not have test cases, So I thought I should create some basic ones.
Basic Test Cases
That's why I tried it right away. While I was working on it, I encountered an issue with java version of Gradle, So I fixed it as this file changes. (Java version 8 -> 17)
The issue related to
com.android.libraryused in root build.gradle.kts and optics build.gradle.kts.